## Summary Follow-up to #9005, addressing the review findings that merged unaddressed. None of them affect a relay. `buzz-ws-client` gains one method. Each one skews what the desktop client measures when the relay is slow, which is the case the load generator exists for. - **Reads stop at the stop.** A desktop HTTP read (including NIP-11) now races the run's stop and is abandoned there without being recorded, as EOSE waits already were. Before, a read that outlived the 15 s shutdown grace got its client cancelled and failed an otherwise healthy run. `Fetcher::finish` also keeps the read task's handle until the task ends, so a client cancelled during the join still aborts the task instead of detaching it. - **Root lookups are bounded.** The desktop's seeded-root lookups, for thread recovery and replies, now run under the desktop's 30 s read timeout and stop, not reqwest's 60 s. `roots()` takes an optional bound, and the basic human passes none. If the stop cuts a reply's lookup short, the reply isn't published. That applies to the basic human too: a reply whose root lookup finishes after the stop is dropped. - **An EOSE that arrives in time stays in time.** While a publish waits for its OK, `NostrWsConnection` buffers every other frame. The session loop used to judge EOSE deadlines before reading that buffer, and read one frame per pass. It now handles every frame already in hand (at most 256 per pass) before judging deadlines. Each frame is judged by when it arrived, not when it is read. `NostrWsConnection` keeps each buffered frame's arrival time, and the new `next_event_received` returns it. So an EOSE that arrived after its deadline while an OK wait held it counts as a timeout, and so does a frame that answers the probe late. Past that cap, a pass defers due deadlines, for at most one timeout from the first pass that defers them. While it is deferring, the pass only drains, so another OK wait can't expire an EOSE that's already in hand, and sustained traffic can't postpone a missing EOSE forever. - **Presence and the silence probe.** Both modes now open the app's live-only `presence` route (`{"kinds":[20001],"authors":[…],"since":…,"limit":0}`, up to 256 co-members) alongside the profile and membership routes. As in the app, presence takes no part in establishment: it isn't resumed or carried, and if it fails it doesn't cut a renewal's carry for the other routes. After a tick with no frame since the previous one, they send the app's probe, `REQ probe-N {"kinds":[44100],"#p":[viewer],"limit":0}`, which shows up as `desktop_probe` and is closed at its EOSE. Only frames actually received count, including a publish's OK when it arrives before the probe's deadline. A reaction with no target or a publish whose OK timed out doesn't count. Expiry is judged after the drain against the probe still outstanding. If no frame arrives within the EOSE deadline, the session ends as failed and the client reconnects with backoff. Before this, desktop runs left out presence fan-out and idle-client probes, so they understated load. - **Seed log.** "memberships added (N people)" now reads "memberships ensured", since a rerun adds nobody. - **Docs.** `perf/LOADGEN.md` notes that the six-read cap and flat 30 s timeout are simplifications (the app has neither), and that `legacy` is a lower bound. The pre-fix app also opened a per-channel route for each open or non-member channel and re-sent every route each tick, and the model leaves both out. Not done: an explicit count of REQs abandoned at a renewal (report polish; planned cancellations still aren't errors). ### What got simpler Reads abandoned at the stop now go through one helper, `run::bounded`, which the desktop reads and the root lookup share. Before, each read had its own timeout and its own stop check. `global_reqs` returns the routes the client actually opens, not a fixed pair. The probe and presence routes add one `Route` variant, one op and about 40 lines of session code. `Route::establishes` is now the one place that says which routes take part in establishment, replacing the two `Replay` special cases. "Heard" used to be inferred by comparing activity schedules before and after each step. It now comes from frames only, so `publish` reports whether the relay answered and that comparison is gone. ## Testing On a Blox workstation, at the tree of this PR's head: - `cargo fmt --all -- --check`, `cargo clippy -p buzz-test-client -p buzz-ws-client -p buzz-cli --all-targets -- -D warnings` - `cargo test -p buzz-test-client --lib` (parallel) and `cargo test -p buzz-ws-client`, plus the `loadgen::desktop` tests five more times New tests, each confirmed to fail when its fix is reverted: - `a_read_in_flight_at_the_stop_is_abandoned_not_waited_for`: an 8 s roster read at the stop. Without the stop race the client outlives `drive`'s 5 s stop limit. - `a_cancelled_finish_still_aborts_the_read_task`: aborting `finish()` mid-join ends the read task. With the old `take()`, the task is detached. - `an_eose_in_time_is_not_expired_behind_a_slow_ok`: EOSEs at 1.2 s, publish OKs at 3.5 s, deadline 2.5 s. Without the drain, all four routes time out. - `a_silent_tick_probes_and_an_unanswered_probe_reconnects`: the first connection never answers its probe, so the client reconnects and its next probe is answered. - `a_probe_answered_behind_a_late_ok_does_not_reconnect`: the probe's EOSE arrives in time, but it sits behind a heartbeat whose OK comes after the probe's deadline. With expiry judged against a deadline captured before the drain, the session fails and reconnects. - `a_publish_ok_in_time_answers_an_outstanding_probe`: no probe EOSE ever arrives, and heartbeat OKs answer each probe. - `a_reaction_with_no_target_is_not_heard_as_a_frame`: targetless reactions several times a second still leave the tick silent, so it probes. - `a_reply_whose_root_lookup_the_stop_cut_short_is_not_published`: the stop cuts an 8 s root search short, and OKs are withheld. No `kind 9` EVENT reaches the relay, and the client returns promptly. - `a_backlog_defers_deadlines_for_at_most_one_timeout`: the deferral bound and its reset. - `a_long_backlog_behind_slow_oks_keeps_its_timely_eoses`: 600 replayed events per REQ behind 3.5 s OKs, with a 1.5 s deadline and heartbeats every second. The test fails if the deferral is timed from the REQ instead of from the first pass that defers, and it fails if a second OK wait can run between the deferred passes. - `presence_is_a_live_only_global_only_while_someone_is_watched`: the route's order and its live-only filter in both modes, and that it's absent with nobody watched. - `a_late_eose_is_not_answered_behind_a_slow_ok`: the timely case above with EOSEs at 3 s instead, so all four routes time out, not succeed. - `a_probe_answered_late_behind_a_slow_ok_reconnects`: a probe's EOSE arrives 0.2 s after its deadline while a heartbeat waits for its OK, so the session fails and reconnects. The test also checks that a heartbeat followed that probe on the same connection, so the test can't pass on a probe that simply went unanswered. - `an_answered_probe_is_closed_at_its_eose`: `CLOSE probe-1` goes out before any next probe. - `routes_establish_once_and_a_renewal_holds_them_until_a_cut` gains a case: a renewal where presence times out keeps the other routes carried and establishes nothing. Each new test fails when its fix is reverted (seven mutants in the first round and six in the review round, run on Blox). The test harness now has a tick override that can go below the scenario's 1 s floor, and records EVENT frames by kind. The fake relay sends a REQ's replayed events after the REQ's delay, not before, and the fake API's slow reads sleep in `block_in_place`. No existing test changed behavior. Existing expectations moved for the presence route (one more live EOSE per client) and for reads now abandoned at the stop. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: Luke Tornquist <tornquist@squareup.com> Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
18 KiB
Relay load generator
buzz-loadgen (in crates/buzz-test-client) seeds a data shape and then
drives a population of simulated humans and agents through a ramp of user
multipliers, reporting latency percentiles, errors and rate-limit rejections
per operation for each step.
cargo run --release -p buzz-test-client --bin buzz-loadgen -- seed perf/scenarios/local-smoke.toml
cargo run --release -p buzz-test-client --bin buzz-loadgen -- run perf/scenarios/local-smoke.toml
cargo run --release -p buzz-test-client --bin buzz-loadgen -- teardown perf/scenarios/<templated>.toml
Scale vectors
| Vector | Scenario knob |
|---|---|
| Communities | shape.communities (each provisioned through POST /operator/communities) |
| Channels | shape.channels_per_community, population.channels_per_member |
| History depth | shape.history_messages_per_channel, human.history_limit |
| Deep threads | shape.thread_roots_per_channel, shape.thread_depth, human.thread_reply_fraction |
| One hot thread | [hot_thread]: seed_replies, authors, replies_per_hour, fetches_per_hour |
| Humans / agents | population.humans, population.agents, multiplied by each [[ramp]] step's users |
| Throughput per client | [human] and [agent] rates |
| Reconnect churn | human.mean_session_secs, population.connect_rate_per_sec |
| Private membership | shape.private_channels |
| Large channels | shape.wide_channels, population.wide_member_fraction, population.wide_activity_share |
| Uneven membership | population.tiers |
| Desktop clients | [desktop]: fraction, mode, windows, threads, tick_secs, backstop_secs, renewal_secs |
shape.thread_depth seeds each thread as a chain: reply k replies to reply
k-1, so the thread's deepest reply sits at depth thread_depth. The relay
rejects depths above 100, so scenarios do too. Threads are seeded in parallel
with each other.
A scenario that cannot be scheduled is rejected when it is parsed: for
example seed_concurrency of 0, human.presence_interval_secs below 1, or a
community_host_template with a port while target.connect_addr is set (the
override maps hostnames, so HTTP would ignore it).
[hot_thread] models one thread that keeps growing, such as a conversation
between busy agents. seed posts its root in community 0, channel 0 and
then seed_replies replies directly under it, concurrently. During run,
authors clients (multiplied by each ramp step's users, like humans and
agents) reply to that root and read its newest 100 replies over HTTP. Their
replies are timed, so humans subscribed to that channel record delivery.
Leave seed_replies and authors at 0 to disable it.
Members are assigned deterministically by global index, so every shard and
seed agree on them without coordination:
shape.wide_channelsreserves the first K channels of each community as wide channels. Each human joins them with probabilitypopulation.wide_member_fraction, on top of its own channels. Agents never do.population.wide_activity_share, when set, is the share of its typing, messages and reactions a member of the wide channels sends into them; the rest goes to its regular channels. Unset, typing and messages pick any of a member's channels equally, so a member of three wide and three regular channels sends half of them into the wide ones, and reactions go to the latest message the member saw. It has no effect on members outside the wide channels.population.tiersis a list of{ fraction, channels }. That fraction of humans joinschannelschannels instead ofchannels_per_member. Fractions sum to at most 1; the rest keepchannels_per_member.- A member's own channels are a run of consecutive channels after the wide ones, starting at its index. With no wide channels and no tiers this is the assignment of earlier versions.
What each client does
- Human: authenticates over WebSocket and subscribes to its channels'
messages, its mentions, typing, and ten peers' presence. On connect it
fetches
history_limitmessages per channel. Then it sends presence heartbeats, typing indicators, messages (some as replies into seeded deep threads) and reactions on Poisson schedules. - Agent: authenticates with a NIP-OA tag from its owner, polls HTTP
/query(channel window plus mentions), posts messages through HTTP/events, and sends encrypted kind:24200 observer frames to its owner. - Desktop human: the
desktop.fractionof humans that model the desktop app instead of the basic human above. They keep the basic human's presence, typing, messages and reactions; the subscriptions and HTTP reads are the app's, described under Desktop clients. - Hot-thread author: finds the seeded hot root, then posts replies to it
through HTTP
/events(hot_reply) and reads the thread through HTTP/query(thread_fetch). Until the root is found every attempt counts as athread_fetcherror, so a run without the seeded thread fails.
Messages carry their send time, so every subscriber records publish→delivery
latency (deliver). Across machines this depends on clock sync.
Modeling a deployment
The [human] and [agent] defaults are round placeholders. To model a known
deployment, divide its hourly event counts by its client counts and set the
results as the scenario's rates. Then a ramp step's users reads as a
multiple of that deployment's population. Keep such scenarios with that
deployment's own configuration.
Targeting and membership
target.connect_addr (host:port) applies only together with
target.community_host_template: the generator then dials the community
hosts there in plaintext, over both WebSocket and HTTP, such as a relay's
in-cluster service. Set ws_url and http_url to the community's public
scheme anyway (wss:// and https:// for a relay behind TLS): Host
headers, NIP-98 u tags and the NIP-42 relay tag keep that scheme, which the
relay checks against its own relay URL. Without a host template, the
generator connects to ws_url and http_url as written and connect_addr
has no effect.
By default channels are open and seeded identities join nothing, so a relay
that requires membership rejects both seed and run. With
shape.private_channels = true, seed creates the channels private and adds
every member: the humans and agents assigned to each channel up to the
largest ramp step, and the hot-thread root and authors in its channel. It
sends kind:9000 events of up to 100 members, seed_concurrency at a time,
signed by the community owner, before posting any history. A rerun adds
nobody new, and any member the relay refuses fails the seed. Seeded history
in a private channel is posted by its own members.
Desktop clients
A desktop client models the subscriptions and reads the desktop app makes,
in two modes: legacy, the app before its client volume fixes, and
current (default), after them. Each request type is its own operation in
the report.
On a cold start it:
- reads the relay's NIP-11 document (
desktop_nip11); - opens its profile and membership subscriptions, a live-only (
limit: 0) presence subscription over up to 256 co-members, which replays nothing and recovers nothing, and its channel subscriptions (desktop_live_eose). With up to ten channels both modes open one per-channel batch that replays the newest 500 events. With more,legacyopens one such batch per ten channels;currentopens one live-only subscription per 2048 channels and replays the channels ten at a time in separate subscriptions it closes at EOSE (desktop_replay_eose). At most four are set up at once, each with a 10 s EOSE timeout; - reads over HTTP, at most six at a time with a 30 s timeout (a
simplification: the app has no read limiter of its own, and its reads
time out after 10 s or 20 s): its roster
(
desktop_roster, paged), channel names (desktop_metadata), sidebar preferences (desktop_sidebar), co-member profiles (desktop_profiles) and statuses (desktop_statuses), the custom emoji set (desktop_emoji), read state (desktop_read_state), unread repair in chunks of 128 channels (desktop_unread), reminders (desktop_reminders), and for each ofwindowsopen channels a window catch-up (desktop_window) and its notices (desktop_notices), and for each ofthreadsopen threads a seeded root lookup and its first thread page (desktop_thread_root,desktop_thread_window). The root lookup is the generator's own search for seeded roots (http_query), cached per channel; a reply's lookup runs on the socket, outside the six, with the same timeout. A window catch-up reads the head page, then follows the cursor in the relay's window bounds (kind 39006) for up to five older pages, until the bounds say history is exhausted.
legacy makes all of these reads as it connects. current reads only
NIP-11, names and sidebar preferences then, and the rest as each
subscription reaches its EOSE ("establishes"): profiles, statuses and emoji
with the profile subscription; roster, read state, unread repair and
reminders with the membership subscription; windows and threads with the
channel subscriptions.
A subscription's replay is cut when it replays 500 events, or, for the
live-only subscription, always: it replays nothing itself. A subscription
that misses its EOSE deadline counts as cut, and so does one the previous
connection never caught up. Only an EOSE catches a subscription up: one
that missed its deadline is recovered, but the next connection cannot
resume or carry it. When a current client reconnects, a profile or
membership subscription whose replay was not cut resumed every change, so
it skips its full read: profiles read nothing unless an earlier read is
still owed, and membership only repairs unreads, without the read-state
snapshot, unless a snapshot read failed since, which a full repair retries.
A cut one reads as on a cold start. The channel subscriptions always
recover the windows and threads.
Every tick_secs the client runs a recovery tick, on its own clock across
connections. In legacy each tick replaces its channel subscriptions and
rereads roster, read state and unread. In current each of the three waits
backstop_secs since it last ran: since the batches were last replaced,
since the roster was last read in full, and since a full unread repair (with
its read-state snapshot) was last asked for. A failed roster read, unread
repair or read-state snapshot is owed and runs again on the next tick; a
repair without the snapshot does not settle an owed snapshot. An owed
profile read runs again when the profile subscription next establishes. A
replacement is live-only and is opened before the subscription it replaces
is closed. A replacement that misses its EOSE deadline is closed, the
subscription it would have replaced stays, and the next tick tries again.
A frame is judged by when it arrived, even if it is read later because a
publish was waiting for its OK: an EOSE that arrived after its deadline is
a timeout. A deadline that passes while frames received in time are still
unread waits for them, for up to one more timeout, so under sustained
traffic a missing EOSE times out up to one timeout late.
In both modes, a tick with no frame from the relay since the previous tick
sends a silence probe, a live-only REQ for the viewer's membership notices
(desktop_probe), closed at its EOSE. Any frame that arrives within 10 s
answers it, a publish's OK included; if none does, the session ends as
failed and the client reconnects with backoff.
legacy is a lower bound on the app before its fixes. That app also gave
each open channel, and each channel it watched without being a member, a
subscription of its own beside the batches, and re-sent every subscription
on each tick; the generator models only the batches.
Every renewal_secs (0 disables it; the first is jittered) the client renews
its identity and reconnects. In legacy that is an ordinary reconnect, which
rereads everything but channel names and sidebar preferences. In current
the subscriptions are carried over: none establishes while their replays
keep continuity, so nothing is read. Once any replay is cut, every
subscription establishes as on a reconnect. With more than ten channels the
live-only subscription is always cut, so the replays, windows, threads and
an unread repair run again. A human's session end
(human.mean_session_secs) is an ordinary reconnect in both modes. Resumed
subscriptions start 960 s before the previous session ended, but not before
300 s before the client started.
Each client runs its reads in one task, at most six at a time. A read that comes due while the same read is running or queued is not added again, so a slow relay does not pile reads up behind it. A read leaves the running set as soon as it settles, so a failed one can retry while a slow one is still under way.
The app also establishes the channel subscriptions when a tick's replacement reaches its EOSE; the generator does not model that.
Sharding
run --shard i/n runs the clients whose global index g satisfies
g % n == i. Identities, community hosts and channel ids derive from
run_id, so shards need no coordination: run seed once, then start n
processes, such as a Kubernetes Indexed Job, with the same scenario. Each
shard reports its own clients; add counts and take the worst percentiles
across shards.
ghcr.io/block/buzz-loadgen:main (and :sha-<7>) packages the binary as the
image entrypoint, published by .github/workflows/loadgen-image.yml from
Dockerfile.loadgen. Mount the scenario and pass the subcommand as the
container arguments, for example run /etc/loadgen/scenario.toml --shard $(JOB_COMPLETION_INDEX)/30. Pin :sha-<7> or a digest for runs you intend
to compare; :main moves. The container runs as UID 10001 with / as its
working directory and no home, so point --report at a writable mount.
Abort
Each step reports every operation from the start of its ramp to the end of
its hold, so connection failures during the ramp count. At the end of the
hold, the run stops if any operation's p99 (publish→delivery included)
exceeds abort.max_p99_ms, if any operation other than delivery has an
error rate above abort.max_error_rate, or if a client exited unexpectedly.
An operation still in flight when the hold ends is reported as pending
but not judged: it has not failed yet. A relay CLOSED on a live
subscription counts as a subscribe_eose error and ends that client's
session. Each connect plus authentication must finish within
target.connect_timeout_secs (default 10). Quota rejections, meaning an HTTP 429 or the relay's
rate-limited: quota exceeded text, are reported as throttled, not errors.
Every other rejection, including rate-limited: shared admission unavailable
(the relay's admission store is down), counts as an error.
Ramp steps must increase users, since clients are only ever added.
When the run stops, clients get 15 seconds to settle what they have in flight
and disconnect. An operation already under way runs to its own deadline
instead of being abandoned: a connect attempt finishes within
target.connect_timeout_secs, and a publish waits at most 30 seconds for its
OK. A stalled connect therefore ends as a connect timeout error and a
healthy one as a success. What settles after the last step is reported in the
shutdown object (ops, failures, abort_reason) and judged by the same
limits as a step, so a connect that never completes fails the run there. A client
still busy when the grace period ends is cancelled; its in-flight operations
are recorded as unfinished at stop errors, and the cancellation fails the run
whatever the limits. Keep target.connect_timeout_secs below 15, or a stalled
connect is cancelled instead of timing out. Publishes, history fetches and
HTTP requests can outlast the grace period (30 s, 30 s and 60 s deadlines), in
which case the client is cancelled and the run fails. Desktop reads, like
EOSE waits, are abandoned at the stop and not recorded, and a reply whose
thread-root lookup the stop cuts short is not published.
The process exits non-zero when a step aborts, a client panics, a client had to
be cancelled, or shutdown.abort_reason is set.
seed exits non-zero unless the relay accepted every planned post.
seed provisions each community with create_only, so it never rotates the
owner of an existing host. A host that already exists is reused only when the
fixture owner derived from run_id owns it (re-running seed for the same
scenario); otherwise seed fails. Use a fresh run_id or a host template
with {run} to avoid colliding with another community.
Teardown
teardown <scenario> removes the communities seed provisioned from
target.community_host_template, using the operator key seed used. For each
host it archives the community as its fixture owner, then requests owner
deletion with a request id derived from run_id and the host. The
relay's deletion drain does the deletion asynchronously; teardown reports
the requests by the stage the relay returned (requested), hosts this run's
fixture owner does not own (absent), and failures. It never touches a host
owned by anyone else, and refuses a scenario without a host template.
Re-running teardown replays the same request ids, so it retries failures
and reports progress without conflicting. It exits non-zero while any
community failed.
Deleted hosts stay reserved as tombstones, so a torn-down run_id cannot be
seeded again: seed fails on the first host. Give each fixture a new
run_id.
Safety
The generator creates real communities, channels and events. Point it only at
environments built for load tests, never at a production relay. Use a fresh
run_id per fixture.