mirror of
https://github.com/block/buzz.git
synced 2026-10-31 14:31:02 +00:00
8ef3d2d88f
The change to `TeamsSection.tsx` made 3 tests fail in `desktop/tests/e2e/team-snapshot.spec.ts`. CI found the failures. This commit corrects them. The 3 tests share a team. Before, they used the default mock team "Engineering", which has no members (`e2eBridge.ts`). The earlier gate used `hasMissingPersonas`, which is false for a team that has no members, and thus the Share item was enabled. The new gate uses `isUsable`, which is correctly false. The Share item is now disabled, and each test stopped at a disabled menu item. The new gate is correct. The `build_team_export_snapshot` function makes one member for each entry in `team.persona_ids`. A team that has no members thus gives a snapshot that has no members, and `validate_team_snapshot` refuses it. The mock replaces the encode command, and therefore the tests did not show this. The 3 tests now seed their own team, and that team has one member. This commit also writes all the comments of this change again in Simplified Technical English (ASD-STE100): short sentences, active voice, no idioms. The text of the delete dialog is simpler too. No production behavior changes in this commit. Co-authored-by: Storme Briscoe <storme@squareup.com> Signed-off-by: Storme Briscoe <storme@squareup.com>