## Summary This is the relay side of owner community deletion. - **Idempotent delete is the recovery call.** - `POST /operator/communities/delete` checks the request UUID first. - If the request already exists with the same host, owner and acknowledgement version, it returns `202` with the request's current `status`. That holds at any stage, even after membership is purged, and no new work is admitted. - The same UUID with a different host or owner returns `409 deletion_request_conflict`. An unsupported acknowledgement version is rejected first, with `400 unsupported_acknowledgement_version`. - There's **no receipt endpoint**. Clients recover by resending. - **Active quota reservation.** An incomplete owner deletion holds the owner's slot until the deletion logically completes. Migration `0054` adds the supporting index. Migrations 0052 and 0053 are unchanged. - **Lifetime cap.** Deleted communities keep their hosts as permanent tombstones. - On create and on transfer-in, the relay counts live ownership plus every non-aborted owner deletion, completed ones included. - That total is capped at an absolute 20, regardless of the active limit, and going over returns `limit_reached`. - This stops create-then-delete host squatting. - **Stable lifecycle conflict codes,** plus `acknowledgement_version` in the 202. - **Owner-list quota projection:** `quota_used`, `quota_limit` and `can_create`. - `can_create` reflects both caps. - The projection is advisory, and `limit_reached` is authoritative. - **Operator doc** (`docs/operator-community-deletion.md`): the acknowledgement version is a compile-time constant. Admission and the executor's claim/lease both filter on it. A version bump must keep replaying and executing old-version requests. This follows on from #7830. The foundation PRs #7818, #7827 and #7830 are merged. ## Testing New tests: - `owner_delete_resubmission_reports_current_status_without_new_intent` - A replay returns 202 `submitted`, including after membership purge. - Changing any field returns 409 `deletion_request_conflict`. - A non-operator gets 403. - A replay after abort returns 202 `aborted`. - No request rows are added. - `completed_owner_deletions_count_toward_lifetime_cap` - After 20 created-then-deleted communities, the active count is 0 but `can_create` is false. - The next create and a transfer-in both return `LimitReached`. - `owner_quota_admits_only_under_active_and_lifetime_caps`: a unit test. Fellowship gate: PASS at `59375c00`. The code review was clean. The E2E run covered authenticated KGoose → relay → the real drain executor. The later commits only change the operator doc. ## Rollout - Deploy order: this relay first, then KGoose squareup/cash-server#130634, then Web squareup/ext-builderbot-ui#241 and App block/buzz-app#403. - No shipped client ever called a receipt route, so removing it doesn't break any existing client. - The quota changes have no deploy-order requirement. - Keep owner deletion off until this relay and the drain executor are live. - If you need to roll back, turn deletion off before rolling back the relay. - Recreate any database that ran the earlier version of migration 0054. That only applies to disposable preview databases. Never apply this to a database holding real data. The earlier draft 0054 has a different checksum and index predicate. ## Complexity Net simpler: - One route, its handler and a writer-routed `get` are removed. Recovery reuses the existing idempotent admission path. - A single `OwnerQuota::admits()` backs create, transfer and the projection. - The stale "clients fail closed / strict deployment order" doc section is replaced by the advisory quota contract. --------- Signed-off-by: tornquist <tornquist@squareup.com> Signed-off-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz> Signed-off-by: Codex <noreply@openai.com> Signed-off-by: Codex <codex@openai.com> Signed-off-by: OpenAI Codex <codex@openai.com> Co-authored-by: Codex <noreply@openai.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz> Co-authored-by: Codex <codex@openai.com>
10 KiB
Community Deletion Operator Job
Buzz executes whole-community deletion through the typed, one-shot
/usr/local/bin/buzz-admin deletions drain command. The Helm chart can schedule
that command as a Kubernetes CronJob; it does not call relay HTTP and it does
not add another queue or retry service.
Postgres remains the handoff and source of truth. A run gives already-approved
work priority. When none is ready, it may claim an operator-attested
owner-origin request at submitted, build the existing bounded inventory, and
atomically freeze that inventory with a digest-bound owner_automatic
approval. The same lease then enters the unchanged executor and resumes from
durable checkpoints.
Operator-origin requests never auto-progress. concurrencyPolicy: Forbid prevents scheduled
pod overlap, backoffLimit: 0 prevents Kubernetes Job retries, and the deletion
store remains authoritative when a pod exits, reaches its deadline, or is
replaced.
Enablement
The CronJob is disabled by default. Production deployments should use an existing Secret and a dedicated, pre-created service account:
secrets:
existingSecret: buzz-operator-secrets
operatorJobs:
deletionDrain:
enabled: true
schedule: "*/5 * * * *"
activeDeadlineSeconds: 3600
terminationGracePeriodSeconds: 30
serviceAccountName: buzz-deletion-drain
podLabels:
tags.datadoghq.com/service: buzz-deletion-drain
podAnnotations:
sidecar.istio.io/inject: "false"
resources:
requests:
cpu: 100m
memory: 256Mi
limits:
cpu: "1"
memory: 1Gi
Set s3.endpoint, s3.bucket, s3.region, and s3.addressingStyle in chart
values. The selected Secret must contain DATABASE_URL and REDIS_URL; it may
contain BUZZ_S3_ACCESS_KEY and BUZZ_S3_SECRET_KEY when the object store uses
static credentials. The pod receives only those connection values and the four
non-secret S3 settings. It does not receive BUZZ_RELAY_PRIVATE_KEY,
BUZZ_GIT_HOOK_HMAC_SECRET, RELAY_URL, or the full Secret through envFrom.
The pod also disables service-account token automounting and Kubernetes service
link environment injection because the executor does not call the Kubernetes
API or discover cluster Services. This disables the ordinary Kubernetes API
token mount, not credentials injected by a platform workload-identity
mechanism.
Leaving operatorJobs.deletionDrain.serviceAccountName empty falls back to the
relay's own service account, including cloud IAM attached through the platform's
workload-identity mechanism. For example, the EKS IRSA admission webhook can
inject its projected web-identity token and AWS environment variables despite
automountServiceAccountToken: false; other platforms provide their own
identity mechanism. The drain pod therefore inherits the relay's cloud role by
default. Create a dedicated service account with only the object-store
permissions listed below and name it explicitly if you want the executor's IAM
blast radius to be smaller than the relay's.
The S3 principal needs the relay's normal object permissions plus bucket-level
s3:ListBucketVersions and object-level s3:DeleteObjectVersion for every
tenant-owned prefix. This also applies to never-versioned buckets because S3
reports their objects with the null version id.
Runbook
-
Confirm database migrations are current. For operator-origin requests, confirm explicit inventory and operator approval with
buzz-admin deletions inspect <request-id>. For owner-origin requests, expect the drain to recordapproval_origin: owner_automatic;approved_byis the immutable mediating operator, not the owner. -
Confirm the selected Secret contains the required keys and the S3 principal has version-list and exact-version delete permissions.
-
Enable the CronJob and inspect its rendered command and environment before rollout.
-
Locate the rendered CronJob by label rather than by guessing its name:
kubectl get cronjob -n <namespace> \ -l app.kubernetes.io/component=deletion-drain,app.kubernetes.io/instance=<release>The name is
<bounded-fullname>-deletion-drain. The chart truncates only the fullname portion when needed so the suffix remains stable within Kubernetes' 52-character CronJob name limit.buzz.fullnamecollapses to the release name when the release name already contains the chart name, sohelm install buzz ...rendersbuzz-deletion-drain, notbuzz-buzz-deletion-drain. -
Start one staffed manual run with
kubectl create job --from=cronjob/<cronjob-name> <job-name>. -
Follow pod logs and re-run
buzz-admin deletions inspect <request-id>to verify lease, checkpoint, retry, blocked, and terminal state. -
If a run fails or times out, fix the recorded dependency or permission failure. Do not add Kubernetes retries: the next scheduled drain consults the durable retry/checkpoint state and resumes only when the store allows it.
-
Use
buzz-admin deletions abortas privileged recovery while a request is still atsubmittedorinventoriedwhen safe preparation cannot continue. Abort preserves the archived community and immutable request evidence. An operator may alsounblocka remediated preparation failure.
Deadlines, termination, and the retry budget
activeDeadlineSeconds is a Kubernetes-side limit, and the deletion store does
not learn why a pod went away. Two consequences matter when reading state:
- A
DeadlineExceededJob is not recorded as a deletion retry. Shutdown releases the claim without recording one, soretry_countandblocked_atdo not advance. Only the object-store drain checkpoints per manifest chunk and resumes mid-stage; every other stage restarts from its beginning on the next run. A deadline that keeps landing inside one of those non-resumable stages therefore repeats indefinitely: each run incrementsattemptsand burns the window again while the retry budget never moves and the request is never blocked. - Diagnose this from both sides.
buzz-admin deletions inspect <request-id>shows a risingattemptswith a flatretry_countand nolast_error; Kubernetes holds the reason. The chart labels the CronJob and the drain pods, but not the generated Jobs, so find the attempts withkubectl get pods -n <namespace> -l app.kubernetes.io/component=deletion-drainand read the condition withkubectl describe job <job-name>.
Size activeDeadlineSeconds for the longest single stage this community will
run, not for the average run. To recover, either raise the deadline and let the
schedule pick the request back up, or take one staffed run with
buzz-admin deletions run <request-id> outside the CronJob's deadline.
terminationGracePeriodSeconds is a best-effort window, not a guarantee. The
drain command handles SIGTERM and releases its lease cleanly when it wins the
race, but a pod that is still working when the grace period expires is
SIGKILLed with the lease still held. Nothing is lost: the durable lease simply
expires (60s by default, heartbeated every 10s) and the next run reclaims the
request with a fresh lease generation, which fences any straggler write from the
killed process. Expect up to roughly a lease duration of delay before the
request is runnable again; do not raise the grace period expecting a clean
handoff.
Owner self-serve relay admission still records only a submitted row and does
no inventory, approval, S3 work, or execution synchronously. A successful drain
has no human approval step or cooling-off period: operator-attested owner intent
is prepared automatically under privileged policy and becomes immediately
eligible for execution. Transient preparation failures use the existing retry
schedule; permanent or exhausted failures block durably. Owner-facing
admission has no cancellation endpoint.
Admission is idempotent on the request UUID. Resending the same UUID with the
same host, owner, and acknowledgement version returns 202 with that request's
current status at any stage, including after membership purge, and admits no
new work. Clients recover an ambiguous submission by resending it. The same
UUID with a different tuple returns 409 deletion_request_conflict.
The acknowledgement version is a compile-time constant
(OWNER_DELETION_ACKNOWLEDGEMENT_VERSION), not operator configuration.
Admission validates it before the UUID lookup, and the executor claims and
leases only requests carrying the current version. Raising it therefore makes
resends of pending requests made under the old version fail with
400 unsupported_acknowledgement_version, and leaves already-admitted
old-version requests unclaimed in submitted. A version bump must ship code
that keeps admitting replays of, and executing, requests at the prior version
until none remain in a non-terminal stage.
Owner quota
The relay enforces two per-owner caps on create and on transfer-in, both as
limit_reached:
- Active: live ownership plus incomplete owner deletions
(
BUZZ_MAX_COMMUNITIES_PER_OWNER, default 5). A deletion keeps its slot until logical completion recordscompleted_at. - Lifetime: live ownership plus every non-aborted owner deletion, including completed ones, capped at an absolute 20 regardless of the active limit. Deleted communities keep their hosts as permanent tombstones, so this bounds create-then-delete host squatting. Aborted deletions restore the community and count only through its live membership.
Owner-list responses carry quota_used (active), quota_limit (active), and
can_create (both caps). can_create: false is the only signal a client needs:
show a generic community-limit message and do not derive a reason from the
counts, because an owner at the lifetime cap can have quota_used below
quota_limit. The projection is advisory: clients may use it for
UX, but the relay's limit_reached is authoritative, and quota changes have no
deployment order. Keep owner deletion off until this relay and the drain
executor are live; on rollback, turn deletion off before rolling back the relay.
The chart has no existing PrometheusRule or provider-neutral CronJob alert integration. Operators must alert on failed/missed Jobs and long-running active Jobs in their deployment platform. Adding a chart-native alert abstraction is debt, not part of this job contract.