mirror of
https://github.com/block/buzz.git
synced 2026-10-30 05:51:46 +00:00
fa276f6f3f
Propagate native query errors; share aggregate presence with cards, menus and lifecycle actions. Keep failed aggregate siblings unknown through live/self updates until successful snapshot retry. Add native command, mounted lifecycle and real-surface request-count regressions. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <loganj@squareup.com>
71 lines
4.5 KiB
Markdown
71 lines
4.5 KiB
Markdown
# Agent availability and lifecycle
|
|
|
|
Availability means conversational presence on the relay, not process health.
|
|
A retained deployment receipt, PID, or `running` record cannot turn an agent's
|
|
availability dot green. A successful presence snapshot with no entry means
|
|
Offline. A pending/failed read or disconnected relay means unknown, including
|
|
when the cache previously contained Online. Online and Away require presence.
|
|
|
|
Agents cards and profiles share the existing presence query and live subscription;
|
|
the Agents action owner queries its full managed set once and passes its reader
|
|
to persona/custom/unknown cards. Members owns one full-roster query shared by
|
|
rows, menus and bulk actions. The profile's actions use its existing snapshot,
|
|
and its popover also preserves failed/disconnected reads as unknown. Native
|
|
query errors reject the IPC call rather than fabricating an empty snapshot.
|
|
A live update or self heartbeat cannot heal a failed aggregate snapshot by
|
|
marking cached siblings successful; those reads remain unknown until a
|
|
successful snapshot retry. No per-row polling is needed, and
|
|
there is no second availability cache or substrate poller. Lifecycle controls
|
|
remain separate: a deployed provider agent still offers Shutdown while offline.
|
|
Shutdown sends a request, not a confirmed termination, and absence of presence
|
|
is not permission to deploy a duplicate body. Local Stop/Start routing is unchanged.
|
|
|
|
A locally stopped record with current exact-key Online or Away presence does
|
|
not establish local process ownership. Its card replaces Start (including a
|
|
stale restart/error badge) with the presence dot; its profile and member menu
|
|
retain the lifecycle-derived Start label but disable activation with an
|
|
explanation. No Stop is invented. Local/pair-owned running controls keep their
|
|
existing Stop/Restart routing, even when presence is Offline. The same positive
|
|
presence guard covers list/profile callbacks and member bulk respawn so the
|
|
visible affordance is not the only fence. This is a UI startup guard, **not** a
|
|
distributed singleton lock: missing, expired, failed or disconnected presence
|
|
cannot certify that starting another body is safe. Existing relay query/live
|
|
subscription freshness remains authoritative; no separate heartbeat or cache
|
|
is introduced. Runtime details remain accessible through the card/profile.
|
|
|
|
|
|
## Regression evidence
|
|
|
|
- `desktop/src-tauri/src/commands/profile_presence_tests.rs`: actual command
|
|
against loopback HTTP; empty success versus auth/rate-limit/storage/malformed
|
|
response and transport failure, with authenticated kind-20001 requests.
|
|
- `UnifiedAgentsSectionCardTarget.test.mjs`: three card types use one request
|
|
and one polling observer, reordered while the snapshot is in flight; exact-key
|
|
live updates, failed warm-cache poll, retry, changed author set and unmount.
|
|
- `agent-availability.spec.ts`: real Agents/Members surfaces request-count check;
|
|
failure uses the native string rejection shape, not a fabricated success.
|
|
|
|
- `desktop/src/features/agents/lib/useAgentAvailability.test.mjs`: successful,
|
|
missing, unavailable, and disconnected presence; lifecycle routing and badges.
|
|
- `desktop/tests/e2e/agent-availability.spec.ts`: deployed/offline profile and
|
|
card, stopped/Online and Away presence, disabled keyboard/click Start in
|
|
profile and member menu, restored Offline startup, running-but-Offline,
|
|
live updates and disconnected-state behavior.
|
|
- `desktop/src/features/agents/ui/UnifiedAgentsSectionCardTarget.test.mjs`:
|
|
mounted persona/custom/unknown cards, exact-key versus other-key presence,
|
|
Online/Away/offline/missing transitions and actual Start callback activation.
|
|
- `desktop/tests/e2e/agents.spec.ts`: Start badge animation and avatar continuity,
|
|
runtime-only negative control, then authored Online presence.
|
|
- `desktop/tests/e2e/profile.spec.ts`: created-agent initial Online snapshot and
|
|
live Offline/Online transitions alongside independent Stop/Start controls.
|
|
- `desktop/tests/e2e/onboarding.spec.ts`: Welcome kickoff stays pending after
|
|
runtime start alone, then greets the owner and addresses Honey/Pollen only
|
|
after the scenario publishes their explicit presence. Healthy-team scenarios
|
|
use `tests/helpers/welcomeTeam.ts`, without changing the product readiness wait.
|
|
|
|
Mock create/start/stop only model runtime bookkeeping. Scenarios that require
|
|
availability use `__BUZZ_E2E_EMIT_MOCK_PRESENCE__` to seed the snapshot and emit
|
|
kind 20001 with the agent as author. Updating a directory row or posting a chat
|
|
message is not presence. Mock browser tests do not certify native relay TTL,
|
|
provider termination, or substrate health.
|