jerry/claude-agent-acp
1
0
Fork 0
mirror of https://github.com/agentclientprotocol/claude-agent-acp.git synced 2026-10-27 04:30:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: clarify stream-id tracking and liveStreamed dedup assumptions

Browse Source 
Add comments explaining (1) why the streamed-id tracking runs for every
stream_event rather than only parent_tool_use_id === null, and that the
single currentStreamingMessageId field is safe given serialized events,
and (2) that the liveStreamed drop is all-or-nothing per message id.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ben Brandt
2026-06-05 11:03:50 +02:00
parent 63b708176e
commit affc731e3a
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/acp-agent.ts
View File

@@ -1093,6 +1093,14 @@ export class ClaudeAcpAgent implements Agent {
// the SDK is talking to a model proxy that never produces
// `content_block_delta` events for the second model call in a
// tool-use loop).
//
// This runs for every stream_event (not gated on
// `parent_tool_use_id === null` like the usage block below) because
// subagent assistant messages flow through the same content filter.
// `currentStreamingMessageId` is a single field, which is safe
// because the SDK serializes the event stream and `message_start`
// always precedes its own `content_block_delta`s, so the captured
// id is always the parent of the deltas that follow.
if (message.event.type === "message_start") {
session.currentStreamingMessageId = message.event.message.id;
} else if (
@@ -1313,7 +1321,14 @@ export class ClaudeAcpAgent implements Agent {
return true;
}
// Already delivered live via streaming deltas — drop the
// assembled copy to avoid duplication.
// assembled copy to avoid duplication. Note this is
// all-or-nothing per message id: a single delta of either
// kind flags the id, so if a gateway streamed (say)
// thinking deltas but delivered text only in the assembled
// message under that same id, the assembled text is
// dropped here. That mixed mode hasn't been observed —
// gateways stream either everything or nothing — and it is
// not a regression (the old code dropped it unconditionally).
if (liveStreamed) {
return false;
}