jerry/claude-agent-acp
1
0
Fork 0
mirror of https://github.com/agentclientprotocol/claude-agent-acp.git synced 2026-10-27 04:30:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: Add explicit type checks for MCP servers (http/sse) (#487)

Browse Source 
As mentioned in
https://github.com/agentclientprotocol/claude-agent-acp/issues/468#issuecomment-4141841845

IDEA always explicitly passes the MCP server type; for example, even if
the type is `stdio`, IDEA will still pass `type: 'stdio'`.

This causes the following code to enter the http or sse branch due to
the presence of the 'type' field

<img width="644" height="483" alt="Image"
src="https://github.com/user-attachments/assets/4919ae2a-456f-461a-93b8-d914489f444c"
/>

As part of defensive programming, change this line to a more robust
check:

`if ("type" in server && (server.type === "http" || server.type ===
"sse"))`
This commit is contained in:
czp
2026-03-27 19:24:47 +08:00
committed by GitHub
parent 93d87c2e71
commit e00a43901f
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/acp-agent.ts
View File

@@ -1256,7 +1256,8 @@ export class ClaudeAcpAgent implements Agent {
const mcpServers: Record<string, McpServerConfig> = {};
if (Array.isArray(params.mcpServers)) {
for (const server of params.mcpServers) {
if ("type" in server) {
if ("type" in server && (server.type === "http" || server.type === "sse")) {
// HTTP or SSE type MCP server
mcpServers[server.name] = {
type: server.type,
url: server.url,
@@ -1265,6 +1266,7 @@ export class ClaudeAcpAgent implements Agent {
: undefined,
};
} else {
// Stdio type MCP server (with or without explicit type field)
mcpServers[server.name] = {
type: "stdio",
command: server.command,