da9f7e5695
Stacked on #1071. The first three commits are that PR; review the last commit here. ## What `--hide-claude-auth` hid the claude.ai login method from `initialize`, but nothing stopped a session from billing a subscription that was already stored. This moves the decision into `src/hide-claude-auth.ts` with two layers: 1. Session creation refuses an account that holds no credential this integration accepts, so a logged-out session never exists. 2. A sign-out during the session ends the query. The next turn recreates it, so the next `initialize` reports the real account. A per-turn guard repeats the check on the account the SDK cached at `initialize`. It reads no process and costs microseconds. It covers a session created under a provider override that `providers/disable` later removed. "Bills a subscription" is an allowlist of `apiKeySource` values that outrank a stored subscription, so an unknown SDK value keeps the guard on. The guard fails open when the account cannot be read at all, and warns once per session. ## Client-visible additions (all additive) - The `authRequired` JSON-RPC error carries `data.reason: "claude_subscription_not_supported"` when the guard blocks a turn. Same error code and same message string as before. A plain sign-out still carries no `data`. - `PublishedSessionFailure` gains an optional `reason`, emitted in the failure `_meta` only when set. `hasActiveSessionError` matches on it, so the subscription refusal and a plain sign-out cannot suppress each other. ## Behavior changes not behind the flag - `providers/set` and `providers/disable` no longer reject the whole call when one session cannot be recreated. The session gets a per-session failure row, the switch goes on to the next session. The affected session is the one signal for that case; AIR never reaches it, because it sends `providers/set` only while a pooled client is created, before any session exists. - `authenticate` validates a gateway payload that is present. A call with no `_meta.gateway` keeps its historical meaning: no override, success. - A failed session creation closes the query it spawned instead of leaking the CLI process. ## Compatibility Checked against Zed and the JetBrains clients (`plugins/llm`, AIR main and stable). No consumer sends a gateway `authenticate` without a payload, none passes `--hide-claude-auth` by default, every one already handles the `auth_required` JSON-RPC rejection, and every `_meta` / error `data` parser ignores unknown fields. ## Test plan - `npm run build`, `npm run check`: clean. - `npm run test:run`: 1153 passed, 27 skipped. - New tests in `src/tests/authorization.test.ts` cover the guard end to end: creation refusal, per-turn refusal, sign-out respawn, provider override on/off, gateway payload validation, degraded guard. ## Follow-up commit in this PR - `fix(auth): start a fresh query when a signed-out session cannot be resumed` — when the CLI never persisted the session, `resume` answers `resourceNotFound`; the respawn now starts a fresh query under the same ACP session id instead of failing every later prompt. Tests after it: 1156 passed, 27 skipped. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
ACP adapter for the Claude Agent SDK
Use Claude Agent SDK from ACP-compatible clients!
This tool implements an ACP agent by using the official Claude Agent SDK, supporting:
- Context @-mentions
- Images
- Tool calls (with permission requests)
- Following
- Edit review
- TODO lists
- Nested subagent transcripts
- Interactive (and background) terminals
- Custom Slash commands
- Client MCP servers
- Session-scoped long-running goals through the provider-neutral goal extension
- Structured errors, recovery, and warnings through the opt-in session failure extension
- Tool permission presentation, editable choices, and durable effects through the permission extension
Learn more about the Agent Client Protocol.
Subagent sessions
Subagents are exposed only after bilateral capability negotiation. Until the released ACP SDKs
preserve the draft clientCapabilities.subagents field, a supporting client may advertise
nativeSubagentSessions in _meta.jetbrains.air.capabilities; the adapter mirrors the capability
in its initialize response. The canonical field remains supported and takes precedence once it is
available. Without either client signal, Agent/Task lifecycle keeps its legacy ordinary ACP
tool-call representation and child interactions stay on the root session. Clients that use the
historical _meta["subagent-transcript"] capability or forwardSubagentText session option retain
the flattened child transcript behavior.
Contribution Policy
This project does not require a Contributor License Agreement (CLA). Instead, contributions are accepted under the following terms:
By contributing to this project, you agree that your contributions will be licensed under the Apache License, Version 2.0. You affirm that you have the legal right to submit your work, that you are not including code you do not have rights to, and that you understand contributions are made without requiring a Contributor License Agreement (CLA).