mirror of
https://github.com/agentclientprotocol/claude-agent-acp.git
synced 2026-10-27 12:40:32 +00:00
f4704c168f
## Summary Partially addresses #639. Builds on #702 which added version-aware matching. When the SDK's `opus` alias resolves to a newer version than what's in `availableModels` (e.g. the SDK was bumped to Opus 4.8 but `availableModels` still contains `claude-opus-4-6[1m]`), the version check from #702 correctly rejects the `opus` entry (4.8 ≠ 4.6). However, the tokenized matcher then falls through to `sonnet[1m]` because the `1m` context hint token alone scores 3 points — enough to win. This causes `claude-opus-4-6[1m]` to display as "Sonnet (1M context)". Fix: `scoreModelMatch` now returns 0 when the only matching token is the context hint. This prevents cross-family matches without hardcoding model family names. Note: Claude initially recommended hardcoding model families to be 100% sure we avoid cross-family matching. While it would be a stronger signal, I didn't find references to model families in the codebase (except for opusplan --> opus) so I'm assuming the family list is transparent to claude-agent-acp. ## Test plan - [x] Added test: `does not inherit display info across mismatched model families` — verifies `claude-opus-4-6[1m]` does not resolve to `Sonnet (1M context)` - [x] Existing tests pass (20/20 in `acp-agent-settings.test.ts`) - [x] New test confirmed to fail on unmodified `main` and pass with the fix --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ACP adapter for the Claude Agent SDK
Use Claude Agent SDK from ACP-compatible clients!
This tool implements an ACP agent by using the official Claude Agent SDK, supporting:
- Context @-mentions
- Images
- Tool calls (with permission requests)
- Following
- Edit review
- TODO lists
- Interactive (and background) terminals
- Custom Slash commands
- Client MCP servers
Learn more about the Agent Client Protocol.
Contribution Policy
This project does not require a Contributor License Agreement (CLA). Instead, contributions are accepted under the following terms:
By contributing to this project, you agree that your contributions will be licensed under the Apache License, Version 2.0. You affirm that you have the legal right to submit your work, that you are not including code you do not have rights to, and that you understand contributions are made without requiring a Contributor License Agreement (CLA).