mirror of
https://github.com/block/buzz.git
synced 2026-11-08 10:21:46 +00:00
fix(projects): remove drawer container focus outline
Suppress the browser-default outline on the programmatically focused drawer while retaining focus indicators on its interactive controls. Signed-off-by: Thomas Petersen <thomasp@squareup.com> Co-authored-by: Thomas Petersen <thomasp@squareup.com>
This commit is contained in:
@@ -221,7 +221,7 @@ export function FocusThreadDrawer({
|
||||
// share a radius — a smaller one here would put two radii on one
|
||||
// element. `shadow-panel-left` draws the left edge and its corners;
|
||||
// see the token for why a `border-l` cannot.
|
||||
"absolute inset-y-0 right-0 flex flex-col overflow-hidden rounded-l-2xl bg-background shadow-panel-left",
|
||||
"absolute inset-y-0 right-0 flex flex-col overflow-hidden rounded-l-2xl bg-background shadow-panel-left outline-hidden",
|
||||
)}
|
||||
aria-label={label}
|
||||
data-testid="focus-thread-drawer"
|
||||
|
||||
@@ -801,6 +801,10 @@ test("commit detail opens from the commits feed with a diff", async ({
|
||||
await expect(page.getByTestId("focus-thread-drawer")).toBeVisible();
|
||||
await page.getByTestId("project-home-context-tasks").click();
|
||||
await expect(page.getByTestId("project-home-workspace-sheet")).toBeVisible();
|
||||
await expect(page.getByTestId("focus-thread-drawer")).toHaveCSS(
|
||||
"outline-style",
|
||||
"none",
|
||||
);
|
||||
const workspaceSheet = page.getByTestId("project-home-workspace-sheet");
|
||||
await expect(workspaceSheet).toHaveAttribute("data-tab", "issues");
|
||||
await expect(
|
||||
|
||||
Reference in New Issue
Block a user