fix(ci): align Projects smoke specs with context chrome

Keep git authors in commit Details instead of the header, and point the smoke tests at the section Create review control and the reading-column width so they stop matching the duplicate context action and the full-bleed files pane.

Signed-off-by: Thomas Petersen <thomasp@squareup.com>

desktop/src/features/projects/ui/ProjectCommitDetailPanel.tsx

@@ -76,11 +76,6 @@ export function ProjectCommitDetailPanel({
                 {commitDateLabel(commit.timestamp)}
               </span>
             ) : null}
-            {commit?.authorName ? (
-              <span className="min-w-0 truncate" title={commit.authorEmail}>
-                by <span className="text-foreground">{commit.authorName}</span>
-              </span>
-            ) : null}
             <ProjectOriginReference
               agentName={originAgentName}
               channelId={originChannelId}

desktop/tests/e2e/project-commit-detail.spec.ts

@@ -693,7 +693,10 @@ test("commit detail opens from the commits feed with a diff", async ({
   await expect(commitHeader).toContainText("Committed");
   await expect(commitHeader).not.toContainText("Brain");
   await expect(commitHeader.locator("img")).toHaveCount(0);
-  await expect(commitDetail).toHaveCSS("max-width", "768px");
+  await expect(commitDetail.locator(":scope > div").first()).toHaveCSS(
+    "max-width",
+    "768px",
+  );
   await expect(
     commitDetail.getByRole("heading", {
       name: "Add Trello board workflow details",
@@ -867,7 +870,7 @@ test("pull request and issue feeds use compact work item rows", async ({
     page.getByTestId("project-work-item-group-header").first(),
   ).toBeVisible();
   await expect(
-    prRows.first().locator("button").filter({ hasText: /.+/ }).nth(1),
+    prRows.first().locator("[data-projects-text-priority='primary']"),
   ).toHaveCSS("font-weight", "400");
   await waitForAnimations(page);
   await page.screenshot({ fullPage: false, path: `${SHOTS}/03-prs-feed.png` });

desktop/tests/e2e/project-pr-review.spec.ts

@@ -3140,7 +3140,10 @@ test("pushed local branch can open a pull request", async ({ page }) => {
     .getByRole("menuitemradio", { name: "feature/projects-workflow" })
     .click();
   await page.getByRole("tab", { name: "Review", exact: true }).click();
-  await page.getByRole("button", { name: "Create review" }).click();
+  await page
+    .getByTestId("project-section-header")
+    .getByRole("button", { name: "Create review" })
+    .click();
   await expect(page.getByTestId("create-pull-request-repository")).toHaveValue(
     /:buzz$/,
   );