Compare commits

...

2 Commits

Author SHA1 Message Date
acp-release-bot[bot]
320f4d70a1 chore(main): release 0.24.2 (#488)
🤖 I have created a release *beep* *boop*
---


##
[0.24.2](https://github.com/agentclientprotocol/claude-agent-acp/compare/v0.24.1...v0.24.2)
(2026-03-27)


### Bug Fixes

* Add explicit type checks for MCP servers (http/sse)
([#487](https://github.com/agentclientprotocol/claude-agent-acp/issues/487))
([e00a439](e00a43901f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: acp-release-bot[bot] <246668977+acp-release-bot[bot]@users.noreply.github.com>
2026-03-27 12:26:03 +01:00
czp
e00a43901f fix: Add explicit type checks for MCP servers (http/sse) (#487)
As mentioned in
https://github.com/agentclientprotocol/claude-agent-acp/issues/468#issuecomment-4141841845

IDEA always explicitly passes the MCP server type; for example, even if
the type is `stdio`, IDEA will still pass `type: 'stdio'`.

This causes the following code to enter the http or sse branch due to
the presence of the 'type' field

<img width="644" height="483" alt="Image"
src="https://github.com/user-attachments/assets/4919ae2a-456f-461a-93b8-d914489f444c"
/>

As part of defensive programming, change this line to a more robust
check:

`if ("type" in server && (server.type === "http" || server.type ===
"sse"))`
2026-03-27 11:24:47 +00:00
5 changed files with 14 additions and 5 deletions

View File

@@ -1,3 +1,3 @@
{
".": "0.24.1"
".": "0.24.2"
}

View File

@@ -1,5 +1,12 @@
# Changelog
## [0.24.2](https://github.com/agentclientprotocol/claude-agent-acp/compare/v0.24.1...v0.24.2) (2026-03-27)
### Bug Fixes
* Add explicit type checks for MCP servers (http/sse) ([#487](https://github.com/agentclientprotocol/claude-agent-acp/issues/487)) ([e00a439](https://github.com/agentclientprotocol/claude-agent-acp/commit/e00a43901fa2b4fd7d582e1de57277be88233007))
## [0.24.1](https://github.com/agentclientprotocol/claude-agent-acp/compare/v0.24.0...v0.24.1) (2026-03-26)

4
package-lock.json generated
View File

@@ -1,12 +1,12 @@
{
"name": "@agentclientprotocol/claude-agent-acp",
"version": "0.24.1",
"version": "0.24.2",
"lockfileVersion": 3,
"requires": true,
"packages": {
"": {
"name": "@agentclientprotocol/claude-agent-acp",
"version": "0.24.1",
"version": "0.24.2",
"license": "Apache-2.0",
"dependencies": {
"@agentclientprotocol/sdk": "0.17.0",

View File

@@ -3,7 +3,7 @@
"publishConfig": {
"access": "public"
},
"version": "0.24.1",
"version": "0.24.2",
"description": "An ACP-compatible coding agent powered by the Claude Agent SDK (TypeScript)",
"main": "dist/lib.js",
"types": "dist/lib.d.ts",

View File

@@ -1256,7 +1256,8 @@ export class ClaudeAcpAgent implements Agent {
const mcpServers: Record<string, McpServerConfig> = {};
if (Array.isArray(params.mcpServers)) {
for (const server of params.mcpServers) {
if ("type" in server) {
if ("type" in server && (server.type === "http" || server.type === "sse")) {
// HTTP or SSE type MCP server
mcpServers[server.name] = {
type: server.type,
url: server.url,
@@ -1265,6 +1266,7 @@ export class ClaudeAcpAgent implements Agent {
: undefined,
};
} else {
// Stdio type MCP server (with or without explicit type field)
mcpServers[server.name] = {
type: "stdio",
command: server.command,